https://bugzilla.redhat.com/show_bug.cgi?id=2231710 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |ngompa13@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |ngompa13@xxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: * Package spec complies with Fedora Packaging Guidelines (forks from mutter) * Package builds (and installs with modified mutter package) * No serious rpmlint issues Things to fix on import: * License tag needs to be converted to SPDX: "GPL-2.0-or-later" * Source0 can be simplified by referencing URL via "%{url}", thus: "%{url}/releases/download/v%{version}/%{name}-%{version}.tar.xz" * "%autosetup -S git -n %{name}-%{version}" specifies default "-n %{name}-%{version}" and that part can be dropped * "%{_libdir}/lib*.so.*" in file list needs to be handled with sonames specified (and optionally macroized) Otherwise... PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2231710 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202231710%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
