https://bugzilla.redhat.com/show_bug.cgi?id=2119987 Frank Crawford <frank@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(negativo17@gmail. | |com) --- Comment #3 from Frank Crawford <frank@xxxxxxxxxxxxxxxxxx> --- @negativo17@xxxxxxxxx I've done a review, and everything pretty much passes. There are just three items I want to confirm before publishing it: > [ ]: Provides: bundled(gnulib) in place as required. > Note: Sources not installed I don't believe there is any bundled(gnulib), and this is just a bug in fedora-review. Is that correct? > [ ]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include I know you have included the LICENSE file from upstream, and also that there has been no new release for some years, but have you or can you add an issue upstream for it to be included in any future release. > [ ]: %check is present and all tests pass. I assume there is no suitable checks and it is unlikely ever to occur. Am I correct about that? Once I get confirmation on those points, I'll publish the review and we should be good to go. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2119987 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202119987%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
