[Bug 2230729] Review Request: rust-gvdb - Read and write GLib GVariant database files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2230729



--- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Ran a scratch build now that all dependencies are available in rawhide, and it
failed:
https://koji.fedoraproject.org/koji/taskinfo?taskID=104697659

As I suspected (I'm getting old), the tests are failing on s390x.
There's two possibilities for the root cause(s):
1. Tests hard-code bytes that are not byte-swapped for big-endian architectures
(i.e. s390x) so the code works correctly, but the tests are broken because they
compare correct results with a broken expected value.
2. Tests are correct, but the underlying code doesn't handle big-endian
architectures correctly.

Case 1 is usually much easier to handle (either by fixing test fixtures or by
ignoring failing tests).
Case 2 can be annoying, since it requires working with upstream to find the
places in the code base where little-endianness is (wrongly) assumed, and
fixing them properly.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2230729

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202230729%23c4
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux