https://bugzilla.redhat.com/show_bug.cgi?id=2231252 --- Comment #15 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Thanks for adding this to Fedora. Initial comments: a) Can you use SPDX identifier GPL-2.0-only or GPL-2.0-or-later See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names b) Perhaps add BuildRequires: aspio-devel c) Some third party code is distributed with the tarball and built: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2231252-yass/fedora-rawhide-x86_64/06265743-yass/builder-live.log.gz Perhaps indicate what is bundled and explain why a version packaged in Fedora cannot be used, see: https://packages.fedoraproject.org/pkgs/gtest/gtest https://packages.fedoraproject.org/pkgs/http-parser/http-parser https://packages.fedoraproject.org/pkgs/abseil-cpp/abseil-cpp https://packages.fedoraproject.org/pkgs/google-benchmark/google-benchmark https://packages.fedoraproject.org/pkgs/xxhash/xxhash BoringSSL is not packaged, but maybe OpenSSL can be used instead: https://packages.fedoraproject.org/pkgs/openssl/openssl Quiche is not available: https://github.com/google/quiche but probably worth packaging separately. Though it currently uses Bazel which is only available as a copr: https://copr.fedorainfracloud.org/coprs/vbatts/bazel/ The build seems to use CMake, so maybe something that can be contributed upstream. Other implementations listed at: https://github.com/quicwg/base-drafts/wiki/Implementations Possibly easier to package are: https://github.com/h2o/quicly https://github.com/p-quic/pquic https://github.com/private-octopus/picoquic https://github.com/alibaba/xquic (Depends on BabaSSL/Tongsou or BoringSSL) Maybe also useful might be: https://packages.fedoraproject.org/search?query=quic d) Can Fedora build macros be used: %cmake %cmake_build %cmake_install See https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/ e) Is golang needed? It seems Go code is used only in tools/ and this has dependencies which are not included. f) The line Source0: https://github.com/Chilledheart/yass/archive/refs/tags/%{version}.tar.gz should be Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz see https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags Though the srpm seems to use full git source rather than a commit as third party code is included. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2231252 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202231252%23c15 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
