[Bug 2228346] Review Request: rust-shellcheck-sarif - Convert shellcheck output to SARIF

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2228346

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |decathorpe@xxxxxxxxx
              Flags|                            |fedora-review?
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |decathorpe@xxxxxxxxx



--- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
This package ships a statically linked binary, you will need to add a license
tag to the subpackage:
https://docs.fedoraproject.org/en-US/legal/license-field/#_rust_packages

There are two macros that help with this task (%cargo_license and
%cargo_license_summary).
The current best practice is to call these macros in %build and use their
output.

You can take a look at git-delta for an example:
https://src.fedoraproject.org/rpms/rust-git-delta/blob/rawhide/f/rust-git-delta.spec

1. using the macros in %build:
https://src.fedoraproject.org/rpms/rust-git-delta/blob/rawhide/f/rust-git-delta.spec#_74-75

2. pasting the output of %cargo_license_summary from the build log and
determining the License tag:
https://src.fedoraproject.org/rpms/rust-git-delta/blob/rawhide/f/rust-git-delta.spec#_31-47

3. attaching the the generated license list / BOM to the built package:
https://src.fedoraproject.org/rpms/rust-git-delta/blob/rawhide/f/rust-git-delta.spec#_53

===

Note that the nest version of rust2rpm will likely automate at least *some* of
these steps with an updated spec template:
https://pagure.io/fedora-rust/rust2rpm/issue/246


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2228346

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202228346%23c2
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux