https://bugzilla.redhat.com/show_bug.cgi?id=2228632 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ Blocks| |177841 (FE-NEEDSPONSOR) --- Comment #13 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Looks good to me, thanks for the update! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === There's some post-import tasks that I usually recommend for Rust packages, but since this isn't going to be imported yet, I'll give those steps later. === Congratulations, you got your first approved package. Before getting sponsored into the packager group, I suggest that you take a look here: https://docs.fedoraproject.org/en-US/fesco/Packager_sponsor_policy/#requirements TL;DR: There's a few ways in which you can demonstrate that you understood the Packaging Guidelines. In my experience, making high-quality, non-binding reviews of other pending packages is is usually a good way to get started. If you decide to continue this way, it's always better to look at a few different packages, i.e. not do reviews for three very similar packages, but for example, one written in C using CMake/meson as build system, maybe one Python package, and one Go / Rust package - you get the idea. Once that's done, feel free to ping me with links to those reviews (or Pull Requests, etc.) - My offer to sponsor you and guide you through the process of submitting your first package still stands. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2228632 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202228632%23c13 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
