https://bugzilla.redhat.com/show_bug.cgi?id=2193261 --- Comment #5 from Peter Oliver <mavit@xxxxxxxxxxxx> --- (In reply to Marc-Andre Lureau from comment #3) > (In reply to Peter Oliver from comment #2) > > (In reply to Marc-Andre Lureau from comment #1) > > > I like the short generic spec! Given that we are likely going to see dozens > > > of those, we should set a good example. > > > > If this works out okay, I intend to turn it into a template: > > https://pagure.io/fork/mavit/rpmdevtools/diff/main..tree-sitter > > looks ok (I wish they would use meson instead, but a bit late now..) Perhaps it’s not too late. The current approach of copying Makefiles into each grammar’s repository isn’t working well. https://github.com/tree-sitter/tree-sitter/issues/1488 > > > Things to look after according to fedora-review: > > > libtree-sitter-java.x86_64: E: shared-library-without-dependency-information > > > /usr/lib64/libtree-sitter-java.so.0.0 > > > > I don't know enough about C development to answer this, but I think this is > > somehow expected because this isn't a stand-alone library, but rather > > something you have to load with libtree-sitter. Perhaps we shouldn't be > > installing it directly into %{_libdir}? > > yeah, it looks like tree-sitter is not explicit about where the libraries > should be located, and users of the libraries can decide that. This could > probably be changed... emacs seems to look at the same location as > libtree-sitter... it should rather be $libdir/tree-sitter/ instead imho. Do we have a sense of how serious this is? Could we successfully explain to upstream the benefit of moving it? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2193261 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202193261%23c5 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
