https://bugzilla.redhat.com/show_bug.cgi?id=2161113 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|benson_muite@xxxxxxxxxxxxx |dominik@xxxxxxxxxxxxxx Flags|fedora-review? | --- Comment #8 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Taking over review. License: LGPL-3.0-or-later and BSD-3-Clause and (MIT or CC0-1.0) and CC-BY-3.0 You should drop "and (MIT or CC0-1.0)" from License:, because it refers to jsoncpp, which is unbundled. You should either drop CC-BY-3.0 as well or include the examples/sintel_trailer-720p.mp4 which this license refers to. Once the above two are fixed, this package is APPROVED. Please delete third_party/jsoncpp in %prep and do try to enable tests now that catch is in Fedora. And these would be nice to have. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2161113 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202161113%23c8 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
