https://bugzilla.redhat.com/show_bug.cgi?id=2224163 Tom "spot" Callaway <spotrh@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |spotrh@xxxxxxxxx Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |spotrh@xxxxxxxxx --- Comment #6 from Tom "spot" Callaway <spotrh@xxxxxxxxx> --- Nothing blocking. Approved. = Review = - rpmlint checks return: blackbox-terminal.x86_64: W: no-manual-page-for-binary blackbox-terminal blackbox-terminal.x86_64: W: no-documentation blackbox-terminal.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/actions/com.raggesilver.BlackBox-fullscreen-symbolic.svg /usr/share/blackbox/icons/hicolor/scalable/actions/com.raggesilver.BlackBox-fullscreen-symbolic.svg blackbox-terminal.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/actions/com.raggesilver.BlackBox-show-headerbar-symbolic.svg /usr/share/blackbox/icons/hicolor/scalable/actions/com.raggesilver.BlackBox-show-headerbar-symbolic.svg blackbox-terminal.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/actions/external-link-symbolic.svg /usr/share/blackbox/icons/hicolor/scalable/actions/external-link-symbolic.svg blackbox-terminal.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/actions/settings-symbolic.svg /usr/share/blackbox/icons/hicolor/scalable/actions/settings-symbolic.svg blackbox-terminal.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/apps/com.raggesilver.BlackBox.svg /usr/share/blackbox/icons/hicolor/scalable/apps/com.raggesilver.BlackBox.svg Maybe consider symlinking those svg files to cut down on install footprint a bit. Not a MUST. - package meets naming guidelines - package meets packaging guidelines - license (GPL-3.0-or-later AND (MIT OR Apache-2.0) AND MPL-2.0) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (0a8b76666ac71a6dc9e05b8084e1c6c53cda880ad1f8f778d9d5de9a6644ad0d) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc <- Should README.md be in there? - Desktop file validated -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2224163 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202224163%23c6 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
