https://bugzilla.redhat.com/show_bug.cgi?id=2228918 --- Comment #8 from zzambers@xxxxxxxxxx --- Thanks for your review. I updated %files to be saner and added dependency. Also I have realized, that whole thing should not probably go to %{_javadir}. Looking at other packages (ant, tomcat), correct thing to do seem to be to install package to %{_datadir} and only place jar files to %{_javadir} and then symlink them. So I have done that. Finally, I was doing some experiments in the meantime, and I was able to make generated doc working (tried switching from saxon to xalan, turned out fix was much easier than I expected). Changes: - added Requires: javapackages-filesystem - updated %files to be saner - moved jedit install dir to %{_datadir}/jedit, only jedit.jar file remains in %{_javadir} - enabled generated doc (using xalan) + added required BuildRequires - updated License to also include license of added doc - removed some trailing spaces in spec Sorry for additional changes. Spec URL: https://download.copr.fedorainfracloud.org/results/zzambers/fedora-pkgs/fedora-rawhide-x86_64/06240960-jedit/jedit.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/zzambers/fedora-pkgs/fedora-rawhide-x86_64/06240960-jedit/jedit-5.6.0-1.fc39.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2228918 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202228918%23c8 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
