https://bugzilla.redhat.com/show_bug.cgi?id=2129442 Carl George 🤠 <carl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |carl@xxxxxxxxxx Flags| |fedora-review? Doc Type|--- |If docs needed, set a value CC| |carl@xxxxxxxxxx Status|NEW |ASSIGNED --- Comment #1 from Carl George 🤠 <carl@xxxxxxxxxx> --- MUST fix items: -------------------------------------------------------------------------------- perl is invoked during %build, so this needs `BuildRequires: perl-interpreter`. https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_build_dependencies -------------------------------------------------------------------------------- I don't believe the obsoletes here will work as intended. It needs to include a release one higher than the last build. Obsoletes: %{oldname} <= 3.2.3-39 https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages -------------------------------------------------------------------------------- The COPYING file must be marked as %license. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text -------------------------------------------------------------------------------- This package creates an unowned directory of /usr/share/perl5/vendor_perl/auto. https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ -------------------------------------------------------------------------------- SHOULD fix items (non-blocker to the review, but consider fixing later): -------------------------------------------------------------------------------- The requires on perl(:MODULE_COMPAT_... is redundant and should be removed. https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_versioned_module_compat_requires_or_perl_libs -------------------------------------------------------------------------------- Patch files are missing comments or links to upstream issues. https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/ -------------------------------------------------------------------------------- There is mixed use of %{buildroot} and $RPM_BUILD_ROOT. Consider using the same style consistently through the spec file. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_and_optflags_vs_rpm_build_root_and_rpm_opt_flags -------------------------------------------------------------------------------- It's not in the guidelines yet, but %patchN usage is deprecated in upstream RPM. Consider using %autopatch, %patch N, or %patch -P N. -------------------------------------------------------------------------------- -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2129442 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202129442%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
