https://bugzilla.redhat.com/show_bug.cgi?id=1993600 Tom "spot" Callaway <spotrh@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spotrh@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |spotrh@xxxxxxxxx Flags| |fedora-review+ Status|NEW |ASSIGNED --- Comment #4 from Tom "spot" Callaway <spotrh@xxxxxxxxx> --- License tag isn't quite right. Core code is GPL-2.0-or-later, but C2HS.hs is BSD-3-Clause, and src/Text/Lexers.hs is LGPL-2.1-or-later. doc/c2hs.xml is GFDL-1.1-no-invariants-or-later, BUT I don't see it packaged here. I think the correct License tag should be: License: BSD-3-Clause AND GPL-2.0-or-later AND LGPL-2.1-or-later Please update the license tag before you commit, but this is otherwise approved. - rpmlint checks return: c2hs.x86_64: W: position-independent-executable-suggested /usr/bin/c2hs c2hs.x86_64: W: no-manual-page-for-binary c2hs c2hs.x86_64: E: incorrect-fsf-address /usr/share/licenses/c2hs/COPYING Not sure if a Haskell binary can be PIE. Defer to you on that. - package meets naming guidelines - package meets packaging guidelines - license tag needs updating, GPL-2.0 text in %doc - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1993600 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201993600%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
