[Bug 1996798] Review Request: ghc-cached-json-file - Locally cache a json file obtained by http

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1996798

Tom "spot" Callaway <spotrh@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |spotrh@xxxxxxxxx
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review+
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |spotrh@xxxxxxxxx



--- Comment #6 from Tom "spot" Callaway <spotrh@xxxxxxxxx> ---
APPROVED (generated packages are so simple)

Good:

- rpmlint checks return:
ghc-cached-json-file-devel.x86_64: E: static-library-without-debuginfo
/usr/lib64/ghc-9.2.6/lib/cached-json-file-0.1.1/libHScached-json-file-0.1.1-9nkhzHX7d8f8HC0nyuYTuZ.a
ghc-cached-json-file-prof.x86_64: E: static-library-without-debuginfo
/usr/lib64/ghc-9.2.6/lib/cached-json-file-0.1.1/libHScached-json-file-0.1.1-9nkhzHX7d8f8HC0nyuYTuZ_p.a
ghc-cached-json-file.x86_64: W: no-documentation
ghc-cached-json-file-prof.x86_64: W: no-documentation
ghc-cached-json-file-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-9.2.6/lib/cached-json-file-0.1.1/libHScached-json-file-0.1.1-9nkhzHX7d8f8HC0nyuYTuZ_p.a

All safe to ignore for Haskell packages.

- package meets naming guidelines
- package meets packaging guidelines
- license (BSD-3-Clause) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- doc subpackage okay
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- devel requires base package n-v-r


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1996798

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201996798%23c6
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux