[Bug 2216743] Review Request: liblc3 - Low Complexity Communication Codec (LC3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2216743



--- Comment #3 from Peter Robinson <pbrobinson@xxxxxxxxx> ---
> No need to add this ldconfig scriptlets, see:
> https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets

I had thought that was moving to the macro, but removed.

> I think the CLI tools will be more proper to put them in -devel sub-package,
> or put them in a new sub-package named -tools.

I put them in a utils sub package, they don't fit in devel, I had left them
there simply because they were just 40kb.

> It seems no tests running on %check build section.

Well that's upstream, but if/when upstream adds tests it means they will
automatically run. I don't see this as an issue as it's not a requirement for
tests.

SPEC: https://pbrobinson.fedorapeople.org/liblc3.spec
SRPM: https://pbrobinson.fedorapeople.org/liblc3-1.0.4-1.fc38.src.rpm

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=104341501


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2216743

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202216743%23c3
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux