[Bug 2228632] Review Request: rust-bzip2-rs - Pure Rust bzip2 decompressor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2228632

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |decathorpe@xxxxxxxxx
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED



--- Comment #9 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Yup, looks good. Package builds successfully and tests run.
One problem remains - one of the subpackages that get build is not installable:

Error: 
 Problem: conflicting requests
  - nothing provides (crate(tinyvec/nightly_const_generics) >= 1.1.0 with
crate(tinyvec/nightly_const_generics) < 2.0.0~) needed by
rust-bzip2-rs+nightly-devel-0.1.2-3.fc39.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use
not only best candidate packages)

The subpackage for the "nightly" feature depends on other nightly-Rust-only
features, which we usually disable in our packages (since we don't ship a
nightly Rust compiler, they are usually useless).

So I would recommend to also remove the "nightly" feature from the [features]
table in Cargo.toml (in addition to the previous changes). Doing this with
"rust2rpm -p" should result in the "rust-bzip2-rs+nightly-devel" subpackage
(i.e. the "%package -n rust-%{crate}+nightly-devel" section) to no longer be
generated.

If you want to reproduce this error locally, you can use the "--postinstall"
flag for mock, which attempts to install any built packages into the build
chroot after a successful build.

Other than that, the package looks good.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2228632

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202228632%23c9
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux