https://bugzilla.redhat.com/show_bug.cgi?id=2228918 Kalev Lember <klember@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |klember@xxxxxxxxxx --- Comment #2 from Kalev Lember <klember@xxxxxxxxxx> --- A few nitpicks as I happened to look at the spec file. I don't know java packaging so the rest is gibberish to me :) > License: GPLv2+ Can you update this to use SPDX? Fedora recently switched to use the SPDX license tags and all new packages are supposed to use them now. > gzip %{buildroot}%{_mandir}/man1/jedit.1 Is this actually needed? I thought there was a brp script that automatically compressed all man pages. > %{_mandir}/man1/jedit.1.gz If you take the gzip line out from above, then it would probably make sense to glob this in the %files section with jedit.1* or similar, which would allow potential changes to the man page compression algorithm in the future (in case brp-compress is updated to compress them with something else). > %description > Programmer's text editor Is there a full sentence you could copy from somewhere and put here? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2228918 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202228918%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
