https://bugzilla.redhat.com/show_bug.cgi?id=2227479 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- A few comments: 1. The license tag is not up to the latest standard wrt/ legal guidance. Simplifying licenses like "(A OR B) AND A" to is explicitly discouraged. So the license tag should be: License: Apache-2.0 AND BSD-3-Clause AND CC0-1.0 AND ISC AND LGPL-2.1-or-later AND MIT AND MPL-2.0 AND Unicode-DFS-2016 AND (Apache-2.0 OR MIT) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (MIT OR Apache-2.0 OR Zlib) AND (Unlicense OR MIT) The only simplifications that *are* OK are 1. deduplicating "(A OR B)" and "(B OR A)" since they are officially equivalent, and 2. dropping parenthesis around expressions like "(A AND B) AND C" - i.e. OR and AND are commutative and associative. Sorting the resulting AND "blocks" alphabetically is also useful to keep the result consistent. It's also helpful to paste the output of %cargo_license_summary into the spec file, since it makes this simpler. 2. In the %files list, I would recommend to make directories explicit: %{_datadir}/%{crate} -> %{_datadir}/%{crate}/ This prevents surprises and / or accidental changes from directories <-> files, which can often be problematic on upgrade (especially since the old workaround is now explicitly blocked by DNF). Making it explicit that something is a directory ensures that this can only happen intentionally (even though it is unlikely to happen for a directory like /usr/share/tiny-dfr/). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2227479 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202227479%23c5 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
