Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ufoai-data - UFO: Alien Invasion data files https://bugzilla.redhat.com/show_bug.cgi?id=425956 ------- Additional Comments From kvolny@xxxxxxxxxx 2008-01-07 12:24 EST ------- (In reply to comment #3) > ping? pong, I was on vacation (In reply to comment #2) > Full review done: > Must Fix: > --------- > * Include an empty %build section, not having a build section can cause > problems in certain cases (or so I have been told) it is there, didn't you look at the old revision? - please check: http://www.hajnet.cz/soubory/ufoai/ufoai-data.spec.2.1.1-2 > * Not all content is licensed under the GPL, I'm afraid this means that ufoai > atm cannot be included in Fedora, see: I guess we have to wait (until the next release) ... let's turn to livna (rpmfusion) meanwhile > Should Fix: > ----------- > * Passing "-n %{name}-%{version}" to %setup is redundant. somehow it did not work for me without it, now it works ... I made a new spec revision, but I won't repack the data (srpm) for now; see http://www.hajnet.cz/soubory/ufoai/ufoai-data.spec.2.1.1-3 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review