https://bugzilla.redhat.com/show_bug.cgi?id=2227573 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues ====== - The License field seems to be incomplete. The files in app/src/qt/spelling, for example, seem to be GPL-3.0-or-later. Also, although the license is given as GPL-2.0-only, I see the "any later version" language in many files. See lib/src/representations/markdown/markdown_lexem.cpp for an example. Some files are dual-licensed, with a Qt commercial license or the BSD-3-Clause license. See app/src/qt/layouts/flow_layout.cpp for an example. - The package SHOULD include a metainfo.xml file. See https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/. This is a SHOULD, not a MUST. I've written several of these. If you want me to write one for this package, I am happy to do so. - I don't expect you to fix this, but upstream should probably know they may have a memory leak. See these messages from the build log: src/mind/mind.cpp: In destructor 'virtual m8r::Mind::~Mind()': src/mind/mind.cpp:78:5: warning: possible problem detected in invocation of 'operator delete' [-Wdelete-incomplete] 78 | delete autolinking; | ^~~~~~~~~~~~~~~~~~ src/mind/mind.cpp:78:12: warning: invalid use of incomplete type 'class m8r::AutolinkingMind' 78 | delete autolinking; | ^~~~~~~~~~~ src/mind/mind.h:44:7: note: forward declaration of 'class m8r::AutolinkingMind' 44 | class AutolinkingMind; | ^~~~~~~~~~~~~~~ src/mind/mind.cpp:78:5: note: neither the destructor nor the class-specific 'operator delete' will be called, even if they are declared when the class is defined 78 | delete autolinking; | ^~~~~~~~~~~~~~~~~~ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v2.0 or later", "*No copyright* GNU General Public License, Version 2", "GNU General Public License", "MIT License", "MIT License BSD 2-Clause License", "BSD 3-Clause License", "GNU General Public License v3.0 or later", "Apache License 2.0", "Mozilla Public License 1.1", "*No copyright* Apache License 2.0", "*No copyright* Boost Software License 1.0", "GNU General Public License, Version 3", "BSD 4-Clause License", "zlib License", "BSD 3-Clause License GNU General Public License v2.0 or later". 292 files have unknown license. Detailed output of licensecheck in /home/jamesjer/2227573-mindforger/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 18958 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mindforger-1.54.0-1.fc39.x86_64.rpm mindforger-debuginfo-1.54.0-1.fc39.x86_64.rpm mindforger-debugsource-1.54.0-1.fc39.x86_64.rpm mindforger-1.54.0-1.fc39.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7ejjg9vw')] checks: 31, packages: 4 mindforger.spec:47: E: rpm-buildroot-usage %build sed -i 's|binfile.path = $$PREFIX/bin/|binfile.path = %{buildroot}%{_bindir}|g' app/app.pro mindforger.spec:48: E: rpm-buildroot-usage %build sed -i 's|$$PREFIX/share|%{buildroot}%{_datadir}|g' mindforger.pro mindforger.spec:44: W: macro-in-comment %{_buildroot} ================= 4 packages and 0 specfiles checked; 2 errors, 1 warnings, 2 badness; has taken 0.5 s ================= Rpmlint (debuginfo) ------------------- Checking: mindforger-debuginfo-1.54.0-1.fc39.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpjmn_har7')] checks: 31, packages: 1 ================= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s ================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.5 s Source checksums ---------------- https://github.com/dvorka/mindforger/archive/1.54.0/mindforger-1.54.0.tar.gz : CHECKSUM(SHA256) this package : 1f274b810cf1a4ee31e7d3aa9adc21660f11d2cfff23e1e6950141d96068de5a CHECKSUM(SHA256) upstream package : 1f274b810cf1a4ee31e7d3aa9adc21660f11d2cfff23e1e6950141d96068de5a Requires -------- mindforger (rpmlib, GLIBC filtered): glibc libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5WebKit.so.5()(64bit) libQt5WebKit.so.5(Qt_5)(64bit) libQt5WebKitWidgets.so.5()(64bit) libQt5WebKitWidgets.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libhunspell-1.7.so.0()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) mindforger-debuginfo (rpmlib, GLIBC filtered): mindforger-debugsource (rpmlib, GLIBC filtered): Provides -------- mindforger: application() application(mindforger.desktop) mindforger mindforger(x86-64) mindforger-debuginfo: debuginfo(build-id) mindforger-debuginfo mindforger-debuginfo(x86-64) mindforger-debugsource: mindforger-debugsource mindforger-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2227573 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Python, Perl, fonts, Haskell, R, Ocaml, PHP, SugarActivity, Ruby, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2227573 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202227573%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
