Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: SDL https://bugzilla.redhat.com/show_bug.cgi?id=226402 ------- Additional Comments From j.w.r.degoede@xxxxxx 2008-01-07 11:05 EST ------- (In reply to comment #8) > Yes, this bug can be closed. > No it can't I just checked SDL.spec in devel CVS and the following items from the review still hold true: Must Fix ======== * From rpmlint: * Drop the . at the end of the -devel package summary * Drop "rm -rf %{buildroot}" from %prep (already done at the begin of %install) * change %build in %changelog to %%build * Drop the static library from -devel * Add "Requires: pkgcconfig" to -devel subpackage for proper ownership of the /usr/%{_lib}/pkgconfig directory * Add "Requires: automake" to -devel subpackage for proper ownership of the /usr/share/aclocal directory Should Fix ========== * remove this line: "CFLAGS="$RPM_OPT_FLAGS" CXXFLAGS="$RPM_OPT_FLAGS" \", this is Superfluous, as %configure already does this itself * remove "README-SDL.txt COPYING CREDITS BUGS" from %files devel's %doc, they are already included in the main %doc, which is required by -devel Or basicly, you didn't fix a _single_ thing from my review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review