[Bug 2121490] Review Request: rust-sodiumoxide - Fast cryptographic library for Rust

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2121490



--- Comment #26 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Thanks for the update, I submitted a scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=104183424

The package seems to build as expected on x86_64 and i686, but it fails on
non-x86 architectures
(aarch64, ppc64le, s390x) because the code uses x86-specific Rust macros:

error: This macro cannot be used on the current target.
                                   You can prevent it from being used in other
architectures by
                                   guarding it behind a cfg(any(target_arch =
"x86", target_arch = "x86_64")).
   --> src/crypto/aead/aes256gcm.rs:198:17
    |
198 |                 is_x86_feature_detected!("aes") &&
is_x86_feature_detected!("pclmulqdq");
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in the macro `is_x86_feature_detected` (in
Nightly builds, run with -Z macro-backtrace for more info)
error: This macro cannot be used on the current target.
                                   You can prevent it from being used in other
architectures by
                                   guarding it behind a cfg(any(target_arch =
"x86", target_arch = "x86_64")).
   --> src/crypto/aead/aes256gcm.rs:198:52
    |
198 |                 is_x86_feature_detected!("aes") &&
is_x86_feature_detected!("pclmulqdq");
    |                                                   
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in the macro `is_x86_feature_detected` (in
Nightly builds, run with -Z macro-backtrace for more info)

Since this is only affecting code for a test, it should be simple to fix.

My suggestion would be to patch line 193 of src/crypto/aead/aes256gcm.rs
from
#[cfg(feature = "std")]
to
#[cfg(all(feature = "std", any(target_arch = "x86", target_arch = "x86_64")))]

Attaching a patch with this change to the spec file fixes compilation issues on
aarch64, ppc64le and s390x, but reveals new test failures on these
architectures:
https://koji.fedoraproject.org/koji/taskinfo?taskID=104184002

---- crypto::aead::aes256gcm::aes_api::test::test_seal_open stdout ----
thread 'crypto::aead::aes256gcm::aes_api::test::test_seal_open' panicked at
'called `Result::unwrap()` on an `Err` value: ()',
src/crypto/aead/aes256gcm.rs:206:40
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- crypto::aead::aes256gcm::aes_api::test::test_seal_open_detached stdout
----
thread 'crypto::aead::aes256gcm::aes_api::test::test_seal_open_detached'
panicked at 'called `Result::unwrap()` on an `Err` value: ()',
src/crypto/aead/aes256gcm.rs:222:40
---- crypto::aead::aes256gcm::aes_impl::test::test_vector_1 stdout ----
thread 'crypto::aead::aes256gcm::aes_impl::test::test_vector_1' panicked at
'assertion failed: `(left == right)`
  left: `0`,
 right: `54`', src/crypto/aead/aes256gcm.rs:74:13
failures:
    crypto::aead::aes256gcm::aes_api::test::test_seal_open
    crypto::aead::aes256gcm::aes_api::test::test_seal_open_detached
    crypto::aead::aes256gcm::aes_impl::test::test_vector_1
test result: FAILED. 248 passed; 3 failed; 0 ignored; 0 measured; 1 filtered
out; finished in 17.30s

Not sure how you want to deal with these.
They don't look "harmless" so it might or might not be a good idea to just skip
these tests.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2121490

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202121490%23c26
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux