https://bugzilla.redhat.com/show_bug.cgi?id=2149953 --- Comment #14 from Fabio Valentini <decathorpe@xxxxxxxxx> --- The spec does look good to me, with the exception of the missing license tag + breakdown for the binary subpackage. Adding """ # Apache-2.0 # Apache-2.0 OR BSL-1.0 # GPL-3.0-or-later # ISC # MIT # MIT OR Apache-2.0 License: Apache-2.0 AND (Apache-2.0 OR BSL-1.0) AND GPL-3.0-or-later AND ISC AND MIT AND (MIT OR Apache-2.0) """ as discussed in https://bugzilla.redhat.com/show_bug.cgi?id=2149953#c10 is the only thing that's still missing, as far as I can see. === The only other problem is that the current version (cfonts 1.1.0) has an outdated dependency and doesn't build right now. The suppors-color crate has been updated to version 2, which cfonts is not compatible with yet. You might want to ask upstream about bumping the supports-color dependency (if possible). I also commented on the upstream ticket that you raised, hopefully I could clear some things up. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2149953 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202149953%23c14 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
