https://bugzilla.redhat.com/show_bug.cgi?id=2109839 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? | |needinfo?(mark.e.fuller@gmx | |.de) Doc Type|--- |If docs needed, set a value Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx CC| |zebob.m@xxxxxxxxx --- Comment #2 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - update to SPDX licensing - don't need this if you're removing the binary %files %license LICENSE %doc CHANGELOG.md FAQ.md MIGRATING.md README.md STYLEGUIDE.md - You should run the test. Some tests are failing, probably network issues : github.com/huaweicloud/golangsdk/acceptance/openstack/networking/v2/peering --- FAIL: TestPeeringList (0.00s) peerings_test.go:14: Unable to create a vpc client: Missing input for argument [authURL] --- FAIL: TestAcceptPeering (0.00s) peerings.go:93: Unable to create a network v2 client: Missing input for argument [authURL] --- FAIL: TestRejectPeering (0.00s) peerings.go:93: Unable to create a network v2 client: Missing input for argument [authURL] --- FAIL: TestPeeringCRUD (0.00s) peerings.go:93: Unable to create a network v2 client: Missing input for argument [authURL] FAIL exit status 1 FAIL github.com/huaweicloud/golangsdk/acceptance/openstack/networking/v2/peering 0.003s - update the SPEC with the latest go2rpm: # Generated by go2rpm 1.9.0 %bcond_without check %global debug_package %{nil} # https://github.com/huaweicloud/golangsdk %global goipath github.com/huaweicloud/golangsdk %global commit d823fe11ceba2353b043a2a5039dc2e4d90f1fc3 %gometa -f %global common_description %{expand: Golangsdk: this is a sdk only using by Huawei inner projects. please refer to https://github.com/huaweicloud/huaweicloud-sdk-go.} %global golicenses LICENSE %global godocs CHANGELOG.md FAQ.md MIGRATING.md README.md\\\ STYLEGUIDE.md Name: %{goname} Version: 0 Release: %autorelease -p Summary: Huawei Golang SDK License: Apache-2.0 URL: %{gourl} Source: %{gosource} %description %{common_description} %gopkg %prep %goprep %autopatch -p1 %generate_buildrequires %go_generate_buildrequires %install %gopkginstall %if %{with check} %check for test in "TestPeeringList" \ "TestAcceptPeering" \ "TestRejectPeering" \ "TestPeeringCRUD" \ "TestRouteList" \ "TestRoutesCRUD" \ ; do awk -i inplace '/^func.*'"$test"'\(/ { print; print "\tt.Skip(\"disabled failing test\")"; next}1' $(grep -rl $test) done %gocheck %endif %gopkgfiles %changelog %autochangelog - License ok - Latest version packaged - Builds in mock - Checks pass, after tweak - No rpmlint errors - Conforms to Go Packaging Guidelines Please update the SPEC and needinfo me for me to approve it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2109839 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202109839%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
