https://bugzilla.redhat.com/show_bug.cgi?id=2227475 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Don't do this: > %global __cargo_is_bin() false The %__cargo_is_bin macro is an internal implementation detail (hence the __ prefix), which can change or be removed at any time (in fact, it *did* change in rust-packaging >= 24). Setting it to false / 0 is an incomplete and hacky way to disable binaries that doesn't correctly affect spec file generation. Instead, patch Cargo.toml to remove binaries: - remove all [[bin]] sections (if present) - add "autobins = false" to the [package] table (if necessary) This way rust2rpm will correctly detect that the package has no binaries and will write a library-only spec file accordingly. === You also don't need to manually list all the skipped tests if they share a common prefix, the "--skip" flag does substring matching unless the "--exact" flag is passed to the test harness as well. If you indeed want to avoid matching on tests that you *don't* want to skip, then add the "--exact" flag. If you don't mind skipping some more tests than necessary, you could simplify the %cargo_test call by using the substring matching. === Note that if you want to package this crate for older Fedora releases as well, you will likely need separate branches / patches, since some dependencies that are only used by librsvg2 currently are at different versions in different branches (f38: lopdf 0.29, f37: lopdf 0.27). I have started providing the same versions of libraries across all Fedora branches to avoid situations like these, but since lopdf is currently only a dependency of librsvg2, it didn't make sense to maintain multiple versions of it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2227475 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202227475%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
