Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-TreeBuilder - Perl parser that builds XML trees https://bugzilla.redhat.com/show_bug.cgi?id=427480 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@xxxxxxxxx ------- Additional Comments From panemade@xxxxxxxxx 2008-01-07 05:27 EST ------- Review for initial SRPM posted in comment 1)Not needed following in SPEC %define perl_vendorlib %(eval "`%{__perl} -V:installvendorlib`"; echo $installvendorlib) %define perl_vendorarch %(eval "`%{__perl} -V:installvendorarch`"; echo $installvendorarch) 2) use simple way instead to use like this %dir %{perl_vendorlib}/XML/ %{perl_vendorlib}/XML/Element.pm %{perl_vendorlib}/XML/TreeBuilder.pm use following %{perl_vendorlib}/XML 3) License should be GPL+ or Artistic 4) use setup -q 5) remove META.yml, MANIFEST and MANIFEST.SKIP from %doc 6) make Group to Development/Libraries 7) missing BR and requires. Add following to SPEC BuildRequires: perl(HTML::Element) BuildRequires: perl(HTML::Tagset) BuildRequires: perl(XML::Parser) Requires: perl(HTML::Element) perl(HTML::Tagset) perl(XML::Parser) 8)%install should use following %{__make} pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT Always keep habit of updating SPEC and SRPM links with updateing release tag and adding what changes you did in SPEC. Provide updated SPEC and SRPM links. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review