https://bugzilla.redhat.com/show_bug.cgi?id=2223012 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- Scott, thank you so much for the review! I will definitely look through what you did for Debian. Comments below. (In reply to Scott Talbert from comment #1) > - Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files directly in %_libdir. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_devel_packages > (ST NOTE: I'm not sure what this issue is referring to - I think everything > is OK in this regard??) I think it's talking about cvc5-java, which contains %{_libdir}/libcvc5jni.so, which has no soname. That's fine, because a JNI library doesn't need an soname. > - Package must not depend on deprecated() packages. > Note: python3-cython0.29 is deprecated, you must not depend on it. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/deprecating-packages/ > (ST NOTE: I think this will go away when cvc5 is built in Rawhide since > Cython 3.0.0 has been built there, assuming cvc5 builds fine with it.) Yes, the BuildRequires is for "%{py3_dist cython}", so it should pull in Cython 3.0.0. I'll do a test build in advance to make sure everything is okay. > - Consider enabling tests (they are run OK on Debian, except on i386 and > mips*) That was an oversight. Thanks for catching it. Since you already figured out which tests use a lot of memory, I'll just copy your excellent work. Thanks again. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2223012 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202223012%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
