https://bugzilla.redhat.com/show_bug.cgi?id=2223012 Scott Talbert <swt@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Scott Talbert <swt@xxxxxxxxxx> --- PACKAGE APPROVED, nothing must-fix. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages (ST NOTE: I'm not sure what this issue is referring to - I think everything is OK in this regard??) - Package must not depend on deprecated() packages. Note: python3-cython0.29 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ (ST NOTE: I think this will go away when cvc5 is built in Rawhide since Cython 3.0.0 has been built there, assuming cvc5 builds fine with it.) - Consider enabling tests (they are run OK on Debian, except on i386 and mips*) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [?]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* GNU General Public License v3.0 or later", "GNU Lesser General Public License, Version 3", "MIT License". 5644 files have unknown license. Detailed output of licensecheck in /home/talbert/fedora-review/copr- build-6208892/review-cvc5/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 27309 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build Maven: [-]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [?]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cvc5-devel , cvc5-libs , cvc5-java , python3-cvc5 [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Packages are noarch unless they use JNI Note: cvc5 subpackage is not noarch. Please verify manually [x]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cvc5-1.0.5-1.fc39.x86_64.rpm cvc5-devel-1.0.5-1.fc39.x86_64.rpm cvc5-libs-1.0.5-1.fc39.x86_64.rpm cvc5-java-1.0.5-1.fc39.x86_64.rpm python3-cvc5-1.0.5-1.fc39.x86_64.rpm cvc5-debuginfo-1.0.5-1.fc39.x86_64.rpm cvc5-debugsource-1.0.5-1.fc39.x86_64.rpm cvc5-1.0.5-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpw5ck9drl')] checks: 31, packages: 8 cvc5.x86_64: W: obsolete-not-provided cvc4 cvc5-devel.x86_64: W: obsolete-not-provided cvc4-devel cvc5-java.x86_64: W: obsolete-not-provided cvc4-java cvc5-libs.x86_64: W: obsolete-not-provided cvc4-libs python3-cvc5.x86_64: W: obsolete-not-provided cvc4-python3 cvc5.x86_64: W: no-manual-page-for-binary cvc5 cvc5-devel.x86_64: W: no-documentation cvc5-java.x86_64: W: no-documentation python3-cvc5.x86_64: W: no-documentation cvc5-java.x86_64: E: invalid-soname /usr/lib64/libcvc5jni.so libcvc5jni.so 8 packages and 0 specfiles checked; 1 errors, 9 warnings, 1 badness; has taken 3.2 s Rpmlint (debuginfo) ------------------- Checking: cvc5-debuginfo-1.0.5-1.fc39.x86_64.rpm cvc5-java-debuginfo-1.0.5-1.fc39.x86_64.rpm cvc5-libs-debuginfo-1.0.5-1.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpxnsb3k_q')] checks: 31, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 4.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "cvc5-java". (none): E: there is no installed rpm "cvc5-debuginfo". (none): E: there is no installed rpm "cvc5-debugsource". (none): E: there is no installed rpm "cvc5-java-debuginfo". (none): E: there is no installed rpm "python3-cvc5". (none): E: there is no installed rpm "cvc5-libs-debuginfo". (none): E: there is no installed rpm "cvc5". (none): E: there is no installed rpm "cvc5-libs". (none): E: there is no installed rpm "cvc5-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 9 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s Unversioned so-files -------------------- cvc5-java: /usr/lib/java/cvc5/libcvc5jni.so cvc5-java: /usr/lib64/libcvc5jni.so python3-cvc5: /usr/lib64/python3.12/site-packages/cvc5/cvc5_python_base.cpython-312-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/cvc5/cvc5_pythonic_api/archive/a04093e60036b83681c6f2cf5cca42bb631b6ce4/a04093e60036b83681c6f2cf5cca42bb631b6ce4.zip : CHECKSUM(SHA256) this package : 893e6c6b5a1b7f9b2a068570d84dd927f763d700db6a93a606db06596e072e38 CHECKSUM(SHA256) upstream package : 893e6c6b5a1b7f9b2a068570d84dd927f763d700db6a93a606db06596e072e38 https://github.com/cvc5/cvc5/archive/cvc5-1.0.5.tar.gz : CHECKSUM(SHA256) this package : a9705569fe36c70291dd1eb6dc5f542d33da51f82da46558e3455ed6995b1b7a CHECKSUM(SHA256) upstream package : a9705569fe36c70291dd1eb6dc5f542d33da51f82da46558e3455ed6995b1b7a Requires -------- cvc5 (rpmlib, GLIBC filtered): cvc5-libs(x86-64) libc.so.6()(64bit) libcvc5.so.1()(64bit) libcvc5parser.so.1()(64bit) libedit.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) cvc5-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) cvc5-libs(x86-64) gmp-devel(x86-64) libcvc5.so.1()(64bit) libcvc5parser.so.1()(64bit) symfpu-devel(x86-64) cvc5-libs (rpmlib, GLIBC filtered): glibc ld-linux-x86-64.so.2()(64bit) libantlr3c.so()(64bit) libc.so.6()(64bit) libcadical.so.0()(64bit) libcocoa.so.0()(64bit) libcryptominisat5.so.5.8()(64bit) libcvc5.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgmp.so.10()(64bit) libkissat.so.0()(64bit) libm.so.6()(64bit) libpoly.so.0()(64bit) libpolyxx.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) cvc5-java (rpmlib, GLIBC filtered): cvc5-libs(x86-64) java-headless javapackages-tools libc.so.6()(64bit) libcvc5.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) python3-cvc5 (rpmlib, GLIBC filtered): cvc5-libs(x86-64) libc.so.6()(64bit) libcvc5.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) rtld(GNU_HASH) cvc5-debuginfo (rpmlib, GLIBC filtered): cvc5-debugsource (rpmlib, GLIBC filtered): Provides -------- cvc5: bundled(minisat2) cvc5 cvc5(x86-64) cvc5-devel: cmake(cvc5) cvc5-devel cvc5-devel(x86-64) cvc5-libs: cvc5-libs cvc5-libs(x86-64) libcvc5.so.1()(64bit) libcvc5parser.so.1()(64bit) cvc5-java: cvc5-java cvc5-java(x86-64) libcvc5jni.so()(64bit) python3-cvc5: python-cvc5 python3-cvc5 python3-cvc5(x86-64) python3.12-cvc5 python3.12dist(cvc5) python3dist(cvc5) cvc5-debuginfo: cvc5-debuginfo cvc5-debuginfo(x86-64) debuginfo(build-id) cvc5-debugsource: cvc5-debugsource cvc5-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review --copr-build 6208892 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Java, C/C++, Generic, Shell-api Disabled plugins: Haskell, PHP, R, fonts, SugarActivity, Ocaml, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2223012 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202223012%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
