https://bugzilla.redhat.com/show_bug.cgi?id=2224412 Maxwell G <maxwell@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #15 from Maxwell G <maxwell@xxxxxxx> --- Final Nitpicks ========== - From %description doc: > This is a documentation for the pulp.pulp_installer collection. You can remove `a` from that sentence. - See the `NOTE:` below about timestamps. Other than that, this packaged is APPROVED. You can fix those two issues on import. You can also add me as a co-admin if you'd like. I'd also branch for epel9 so Fedora Infra can use the collection. Thanks! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v2.0 or later", "GNU General Public License, Version 2", "GNU General Public License", "*No copyright* GNU General Public License, Version 2". 324 files have unknown license. Detailed output of licensecheck in /home/gotmax/Sync/git- repos/packaging/fedora_rpms/review.repos/2224412-ansible-collection- pulp-pulp-installer/2224412-ansible-collection-pulp- pulp_installer/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [ ]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. NOTE: noarch package [-]: %check is present and all tests pass. NOTE: package does not provide unit tests [!]: Packages should try to preserve timestamps of original installed files. cp -r --dereference docs %{buildroot}%{_docdir}/%{name}-doc should be cp -p -r --dereference docs %{buildroot}%{_docdir}/%{name}-doc [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ansible-collection-pulp-pulp_installer-3.22.1-1.fc38.noarch.rpm ansible-collection-pulp-pulp_installer-doc-3.22.1-1.fc38.noarch.rpm ansible-collection-pulp-pulp_installer-3.22.1-1.fc38.src.rpm ========================================= rpmlint session starts ======================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpogp_9tc1')] checks: 31, packages: 3 ansible-collection-pulp-pulp_installer.noarch: E: version-control-internal-file /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/plugins/modules/.gitignore ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/galaxy_post_install/files/collection_sign.sh 644 /usr/bin/env bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/galaxy_post_install/files/collection_sign.sh.el7 644 /usr/bin/env bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/galaxy_post_install/files/container_sign.sh 644 /usr/bin/env bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_common/scripts/move-artifacts-to-media-root.sh 644 /usr/bin/env bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_common/scripts/print_status.sh 644 /bin/bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_database/templates/postgresql_scl_profile.j2 644 /bin/bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_redis/templates/redis_scl_profile.j2 644 /bin/bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_webserver/files/identify_snippets.py 644 /usr/bin/env python ansible-collection-pulp-pulp_installer.noarch: W: hidden-file-or-dir /usr/share/doc/ansible-collection-pulp-pulp_installer/CHANGES/.TEMPLATE.md ansible-collection-pulp-pulp_installer.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_database_config/vars/main.yml /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_database/vars/Debian.yml:/usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_database/vars/Fedora.yml ansible-collection-pulp-pulp_installer.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_redis/vars/Fedora-32.yml /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_redis/vars/CentOS.yml ansible-collection-pulp-pulp_installer.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_redis/vars/RedHat-9.yml /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_redis/vars/Fedora-33.yml:/usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_redis/vars/Fedora-34.yml ========== 3 packages and 0 specfiles checked; 9 errors, 4 warnings, 9 badness; has taken 0.3 s ========= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 NOTE: These are alright. ansible-collection-pulp-pulp_installer.noarch: E: version-control-internal-file /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/plugins/modules/.gitignore ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/galaxy_post_install/files/collection_sign.sh 644 /usr/bin/env bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/galaxy_post_install/files/collection_sign.sh.el7 644 /usr/bin/env bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/galaxy_post_install/files/container_sign.sh 644 /usr/bin/env bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_common/scripts/move-artifacts-to-media-root.sh 644 /usr/bin/env bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_common/scripts/print_status.sh 644 /bin/bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_database/templates/postgresql_scl_profile.j2 644 /bin/bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_redis/templates/redis_scl_profile.j2 644 /bin/bash ansible-collection-pulp-pulp_installer.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_webserver/files/identify_snippets.py 644 /usr/bin/env python ansible-collection-pulp-pulp_installer.noarch: W: hidden-file-or-dir /usr/share/doc/ansible-collection-pulp-pulp_installer/CHANGES/.TEMPLATE.md ansible-collection-pulp-pulp_installer.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_database_config/vars/main.yml /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_database/vars/Debian.yml:/usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_database/vars/Fedora.yml ansible-collection-pulp-pulp_installer.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_redis/vars/Fedora-32.yml /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_redis/vars/CentOS.yml ansible-collection-pulp-pulp_installer.noarch: W: files-duplicate /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_redis/vars/RedHat-9.yml /usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_redis/vars/Fedora-33.yml:/usr/share/ansible/collections/ansible_collections/pulp/pulp_installer/roles/pulp_redis/vars/Fedora-34.yml 2 packages and 0 specfiles checked; 9 errors, 4 warnings, 9 badness; has taken 0.1 s Source checksums ---------------- https://github.com/pulp/pulp_installer/archive/3.22.1/pulp.pulp_installer-3.22.1.tar.gz : CHECKSUM(SHA256) this package : 12fd9c04839fe7df5ba001fccdd51a31f205bcc42648d9dd91f083b91688feb5 CHECKSUM(SHA256) upstream package : 12fd9c04839fe7df5ba001fccdd51a31f205bcc42648d9dd91f083b91688feb5 Requires -------- ansible-collection-pulp-pulp_installer (rpmlib, GLIBC filtered): (ansible-core or (ansible < 2.10.0 with ansible >= 2.9.10)) /usr/bin/sh ansible-collection(ansible.posix) ansible-collection(community.crypto) ansible-collection(community.general) ansible-collection(community.postgresql) ansible-collection(mdellweg.filters) ansible-collection-pulp-pulp_installer-doc (rpmlib, GLIBC filtered): Provides -------- ansible-collection-pulp-pulp_installer: ansible-collection(pulp.pulp_installer) ansible-collection-pulp-pulp_installer ansible-collection-pulp-pulp_installer-doc: ansible-collection-pulp-pulp_installer-doc Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -m fedora-38-x86_64 -b 2224412 Buildroot used: fedora-38-x86_64 Active plugins: Generic, Shell-api Disabled plugins: R, Java, Ocaml, C/C++, Python, Haskell, fonts, Perl, SugarActivity, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2224412 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202224412%23c15 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
