[Bug 427586] Review Request: kerneloops - Tool to automatically collect and submit kernel crash signatures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kerneloops -  Tool to automatically collect and submit kernel crash signatures


https://bugzilla.redhat.com/show_bug.cgi?id=427586


tibbs@xxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From tibbs@xxxxxxxxxxx  2008-01-07 01:21 EST -------
Looks much better.  A new rpmlint warning has appeared:
  kerneloops.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/kerneloops.dbus
Looking at whether other packages have these files marked %config, it seems that
many packages do, although several like NetworkManager, ConsoleKit, cups and gdm
don't.  However, all package I have installed on my system actually call the
files *.conf.  We really don't have any guidelines here as far as I can tell so
honestly I'm not going to complain.

Everything now matches upstream:
   ea3bb4779ec74e2af5556d8551dbde6460c41930d61d0f5ef9924dfb42229deb  
   kerneloops-0.10.tar.gz

The permission issues are fixed.

About enabling the service by default, you could make the argument that the
whole point of httpd is to serve web pages, and yet it's not started by default.
 However, this service isn't network-facing and so I can't really make a
security argument.  And my personal preferences aside, we don't have any
specific guideline regarding the issue, so I won't block on it.

So, it seems that all the complaints I had are either addressed or moot.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]