https://bugzilla.redhat.com/show_bug.cgi?id=2219154 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ Doc Type|--- |If docs needed, set a value Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- > %gocheck -d storj.io/picobuf/internal/sizebench you should put: %gocheck -d internal/sizebench Also you should explain why you skip a test, either network/credentials needed, or a bug report upstream saying X test don't work. Here after investigation, it turns out it was fixed upstream in https://github.com/storj/picobuf/commit/2a1eb9b8853cfa90a5c53f28c1eb832594f84570 for Go >= 1.20 You could backport the patch to your spec: Name: %{goname} Release: %autorelease Summary: Small replacement for subset of protobuf License: MIT URL: %{gourl} Source: %{gosource} Patch: https://github.com/storj/picobuf/commit/2a1eb9b8853cfa90a5c53f28c1eb832594f84570.patch Secondly, in such case, it would be preferable to skip the problematic test only, not the entire directory : # https://github.com/storj/picobuf/commit/2a1eb9b8853cfa90a5c53f28c1eb832594f84570 for test in "TestMessageSize" \ ; do awk -i inplace '/^func.*'"$test"'\(/ { print; print "\tt.Skip(\"disabled failing test\")"; next}1' $(grep -rl $test) done - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Go Packaging Guidelines Package approved. I'll let you choose the wy you want to deal with the failing test. Best option would be to patch IMHO. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2219154 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202219154%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
