https://bugzilla.redhat.com/show_bug.cgi?id=2217892 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #10 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to zzambers from comment #7) > Fixed: > - license files use %license > - License name fixed to valid SPDX and added comment > - removed jpackage-utils dependency from javadoc pacakge That all looks great. > - both patches now use -p1 and make use of %autopatch (%autosetup did not > work because it expected ant-contrib-1.0 dir in unpacked source rather than > ant-contrib) That's fine. Just for your information, %autosetup takes the -n argument as well, so you could write it like this: %autosetup -p1 -n %{name} > - find commands removing binaries simplified > - added -p to cp command > - fixed typo in word "deprecated" in changelog That looks great, too. > Kept: > - compilation warnings (I kept this for a time being, I can fix that later, > if it becomes a problem) Sure, that's reasonable. > - non-conffile-in-etc: %{_sysconfdir}/ant.d/ant-contrib - this is not really > config file for user to edit, but rather a way to registers ant-contrib to > ant [2], so I have not marked it as config (btw. apache-ivy does the same > [3]) Okay, good to know. One other note. Even though commons-httpclient was retired, that functionality is available from httpcomponents-client, although with a somewhat different interface. If you find yourself needing the httpclient functionality, it should be possible to port to httpcomponents-client. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2217892 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202217892%23c10 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
