https://bugzilla.redhat.com/show_bug.cgi?id=2217892 --- Comment #7 from zzambers@xxxxxxxxxx --- Thank you for review. I have updated package: Spec URL: https://download.copr.fedorainfracloud.org/results/zzambers/fedora-pkgs/fedora-rawhide-x86_64/06214275-ant-contrib/ant-contrib.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/zzambers/fedora-pkgs/fedora-rawhide-x86_64/06214275-ant-contrib/ant-contrib-1.0-0.42.b3.fc39.src.rpm Sorry for that delay, only now got to that. Changes: [1] Fixed: - license files use %license - License name fixed to valid SPDX and added comment - removed jpackage-utils dependency from javadoc pacakge - both patches now use -p1 and make use of %autopatch (%autosetup did not work because it expected ant-contrib-1.0 dir in unpacked source rather than ant-contrib) - find commands removing binaries simplified - added -p to cp command - fixed typo in word "deprecated" in changelog Kept: - compilation warnings (I kept this for a time being, I can fix that later, if it becomes a problem) - non-conffile-in-etc: %{_sysconfdir}/ant.d/ant-contrib - this is not really config file for user to edit, but rather a way to registers ant-contrib to ant [2], so I have not marked it as config (btw. apache-ivy does the same [3]) [1] https://src.fedoraproject.org/fork/zzambers/rpms/ant-contrib/c/629172303a0074afacafeb35fa9d29ea829b89b8?branch=fix-build-v2 [2] https://stackoverflow.com/a/2949734 [3] https://src.fedoraproject.org/rpms/apache-ivy/blob/85df0ca27e1264a173a0eb7e2a44e41ea0ef72b6/f/apache-ivy.spec#_146 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2217892 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202217892%23c7 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
