https://bugzilla.redhat.com/show_bug.cgi?id=2224960 --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Davide Cavalca from comment #3) > It's totally possible I misunderstood things, but here's what I was trying > to do. tiny-dfr (which is what I'm ultimately trying to package here) needs > input which needs input-sys. input-sys provides versioned bindings for a > bunch of libinput versions, but _not_ for the one currently in Fedora > (1.23). It also provides a feature to generate the bindings instead of using > prebuilt ones, so I figured making that the default (and adjusting input > accordingly to make it the default) would result in things being more > maintainable. Lemme try the glib-sys approach instead, thanks. Ah, looking into the crate's source code, I see why you did what you did now. This crate is doing things in a quite unusual way - they ship pre-generated bindings for different libinput versions and architectures. This is certainly not what we want ... so your previous approach of removing those features and using bindgen to force regenerating the bindings for the current architecture + version should be much better (not even sure if using pregenerated bindings would work, since they're missing for ppc64le and s390x). Sorry about the confusion! (The reason I thought this was weird is that usually the features for versioned bindings are additive (i.e. only add bindings for things that have been added compared to previous versions), so using the latest one is fine (since it should usually imply all the previous ones). This is not the case for this crate, because they ship pre-generated bindings for different versions, and use different files depending on the feature flags that were passed.) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2224960 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202224960%23c7 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
