https://bugzilla.redhat.com/show_bug.cgi?id=2223179 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(code@musicinmybra | |in.net) | --- Comment #1 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- The package is APPROVED, with suggestions. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Notes (no change required for approval) ===== - Versions 0.29.2, 0.29.3, and 0.30.0 are available. The source diff, https://github.com/python-jsonschema/referencing/compare/v0.29.1...v0.30.0 does not show anything that would require packaging changes. In 0.30.0, upstream has declared official support for Python 3.12. (The test suite was updated to fe891e8ae5af7b623ed88db1f48ffb53eba9da21.) Please update to the latest version at your earliest convenience. - Using the %{pypi_source} macro with zero arguments is deprecated: Source0: %{pypi_source} Write %{pypi_source %{srcname}} instead. (My preference would be to drop the srcname macro and write out referencing everywhere it appears; I don’t think it this layer of indirection makes the spec file more legible or reusable in practice. However, this is purely a matter of subjective taste.) - This is pretty noisy: # Unpack the test reference suite %setup -n %{srcname}-%{version} -a1 Consider adding the -q argument to %setup. python-referencing.spec:53: W: setup-not-quiet - Normally I would suggest generating the test dependencies with %pyproject_buildrequires test-requirements.in rather than using manual BuildRequires. In this case, you would need to adjust the file in %prep first: # No fancy stuff! sed -r 's/^file:/# &/' test-requirements.in | tee test-reqs.txt and then use the filtered requirements file. You might like that approach, or you might feel that it’s just as easy to keep writing out the BuildRequires for testing manually. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 318 files have unknown license. Detailed output of licensecheck in /home/ben/Downloads/review/2223179-python- referencing/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.12, /usr/lib/python3.12/site- packages (spurious; these are owned by python3.12) [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.12, /usr/lib/python3.12/site-packages (spurious; these are owned by python3.12) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. $ rpm -qL -p results/python3-referencing-0.29.1-1.fc39.noarch.rpm /usr/lib/python3.12/site-packages/referencing-0.29.1.dist-info/licenses/COPYING [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. (Tests pass) [!]: Latest version is packaged. Versions 0.29.2, 0.29.3, and 0.30.0 are available. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) OK: rpmautospec differences only. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-referencing-0.29.1-1.fc39.noarch.rpm python-referencing-0.29.1-1.fc39.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpp2owog1b')] checks: 31, packages: 2 python-referencing.src: W: strange-permission python-referencing.spec 600 python-referencing.spec:53: W: setup-not-quiet python3-referencing.noarch: W: no-documentation ================ 2 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.6 s ================ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 python3-referencing.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/python-jsonschema/referencing-suite/archive/fe891e8ae5af7b623ed88db1f48ffb53eba9da21/referencing-suite-fe891e8.tar.gz : CHECKSUM(SHA256) this package : 92e165b7b457a4e364cf76cffce640b1d1858115d705c6e6974bba03578f8365 CHECKSUM(SHA256) upstream package : 92e165b7b457a4e364cf76cffce640b1d1858115d705c6e6974bba03578f8365 https://files.pythonhosted.org/packages/source/r/referencing/referencing-0.29.1.tar.gz : CHECKSUM(SHA256) this package : 90cb53782d550ba28d2166ef3f55731f38397def8832baac5d45235f1995e35e CHECKSUM(SHA256) upstream package : 90cb53782d550ba28d2166ef3f55731f38397def8832baac5d45235f1995e35e Requires -------- python3-referencing (rpmlib, GLIBC filtered): python(abi) python3.12dist(attrs) python3.12dist(rpds-py) Provides -------- python3-referencing: python-referencing python3-referencing python3.12-referencing python3.12dist(referencing) python3dist(referencing) Diff spec file in url and in SRPM --------------------------------- --- /home/ben/Downloads/review/2223179-python-referencing/srpm/python-referencing.spec 2023-07-21 10:44:32.989602368 -0400 +++ /home/ben/Downloads/review/2223179-python-referencing/srpm-unpacked/python-referencing.spec 2023-07-15 20:00:00.000000000 -0400 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.3.5) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global srcname referencing @@ -66,3 +76,4 @@ %changelog -%autochangelog +* Sun Jul 16 2023 John Doe <packager@xxxxxxxxxxx> - 0.29.1-1 +- Uncommitted changes Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2223179 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: Ocaml, fonts, SugarActivity, Perl, PHP, R, C/C++, Haskell, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2223179 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202223179%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
