https://bugzilla.redhat.com/show_bug.cgi?id=2221739 Sandro <gui1ty@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gui1ty@xxxxxxxxxxxxx --- Comment #1 from Sandro <gui1ty@xxxxxxxxxxxxx> --- I was just looking at this review request as well. It seems we are at each other's tail this morning FranciscoD_. ;-) I'll leave the review to you. But I have a question regarding the Versioneer foo applied in the spec file: Is this package specific? If so, what does the package do with/to Versioneer that makes it necessary to have an elaborate bcond in the spec file? If not, is this what we are doomed to apply to every package using Versioneer? I hope not, since Versioneer is a pain as it is and this would be like a salty bandaid on top. This package at least has an up to date versioneer.py (0.28). That should work across all branches. Why bother with the system provided version at all? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2221739 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202221739%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
