https://bugzilla.redhat.com/show_bug.cgi?id=2119984 --- Comment #17 from Frank Crawford <frank@xxxxxxxxxxxxxxxxxx> --- I'm approving this, although for completeness, here are the responses about listed issues: > [x]: Package requires other packages for directories it uses. > Note: No known owner of /usr/share/c_icap/templates/srv_url_check, > /usr/lib64/c_icap, /usr/share/c_icap/templates/srv_url_check/en, > /usr/share/c_icap/templates/srv_content_filtering, > /usr/share/c_icap/templates/virus_scan, /usr/share/c_icap, > /usr/share/c_icap/templates/virus_scan/en, > /usr/share/c_icap/templates, > /usr/share/c_icap/templates/srv_content_filtering/en > Note: owned by c-icap package, which is required by this package. > [-]: Package must own all directories that it creates. > Note: Directories without known owners: > /usr/share/c_icap/templates/srv_url_check, > /usr/share/c_icap/templates/virus_scan/en, > /usr/share/c_icap/templates/srv_url_check/en, > /usr/share/c_icap/templates/srv_content_filtering, > /usr/share/c_icap/templates/srv_content_filtering/en, > /usr/share/c_icap/templates/virus_scan > Note: directories owned by c-icap package, which is required by this > package. As noted, these directories are owned by the c-icap package, which is required by this package. > [!]: %check is present and all tests pass. > Note: no tests provided by upstream for this package This is a SHOULD item and there are no tests for these libraries provided by upstream. > [!]: Package should not use obsolete m4 macros > Note: Some obsoleted macros found, see the attachment. > See: https://fedorahosted.org/FedoraReview/wiki/AutooTools > Note: Reported upstream and may be fixed in next release. This is an EXTRA item and has been reported upstream. It is expected to be fixed in the next release. > c-icap-modules.x86_64: W: non-standard-gid /etc/c-icap/clamav_mod.conf c-icap > c-icap-modules.x86_64: W: non-standard-gid /etc/c-icap/clamd_mod.conf c-icap > c-icap-modules.x86_64: W: non-standard-gid /etc/c-icap/srv_url_check.conf c-icap > c-icap-modules.x86_64: W: non-standard-gid /etc/c-icap/virus_scan.conf c-icap Warning, but package is running as a non-root user and these relate to this group, which is used appropriately. > c-icap-modules.x86_64: E: non-readable /etc/c-icap/clamav_mod.conf 640 > c-icap-modules.x86_64: E: non-readable /etc/c-icap/clamd_mod.conf 640 > c-icap-modules.x86_64: E: non-readable /etc/c-icap/srv_url_check.conf 640 > c-icap-modules.x86_64: E: non-readable /etc/c-icap/virus_scan.conf 640 These permissions are required for the non-root user to access the files. > c-icap-modules.x86_64: W: unused-direct-shlib-dependency /usr/lib64/c_icap/srv_url_check.so /lib64/liblmdb.so.0.0.0 Warning only, but is required for dynamic linking. > c-icap-modules.x86_64: W: undefined-non-weak-symbol /usr/lib64/c_icap/clamav_mod.so CI_DEBUG_LEVEL (/usr/lib64/c_icap/clamav_mod.so) > ... Warning only, but are defined in c-icap libraries, and resolved during dynamic linking. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2119984 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202119984%23c17 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
