Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: themonospot - pplication that can be used to scan an avi file and extract some informations about audio and video data flow https://bugzilla.redhat.com/show_bug.cgi?id=427674 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: <main |Review Request: themonospot |package name here> - <short |- pplication that can be |summary here> |used to scan an avi file and | |extract some informations | |about audio and video data | |flow ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2008-01-06 16:22 EST ------- Needs lots of work. Most obvious errors: - GPL is no longer a valid license tag. See http://fedoraproject.org/wiki/Licensing/ for details - Applications/AudioVideo is not one of the standard groups - your %descriptions lacks a subject for the phrase that is included in the first paragraph. I also suggest to use "Using themonospot it is also possible to modify FourCC informations <rest of phrase here>" for the second paragraph. - the %distribution and %vendor tags should not be included in your spec (see http://fedoraproject.org/wiki/Packaging/Guidelines) - Please use rpm macros instead of absolute paths (i.e. replace "./configure --prefix=/usr" with "%configure --prefix=%{_prefix}" or even better just with %configure ) - the desktop file should be installed according to http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755, not using ln;pixmaps should probably be included in %files - the .pc file should probably not be included - the version reported by the most recent entry in the changelog is not identical to the one of the package (0.6.5 versus 0.6.5-1) And last but not least, you should provide access to the src.rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review