Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libvpd - C++ library for system vpd access https://bugzilla.redhat.com/show_bug.cgi?id=307891 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-01-06 10:23 EST ------- For 1.5.0-0: * Source tarball - The source tarball in your srpm is different from what I downloaded from the URL written as Source0. ----------------------------------------------------------- $ ls -al *1.5.0*gz *1.5.0*/*gz -rw-r--r-- 1 tasaka1 tasaka1 356056 2008-01-04 04:02 libvpd-1.5.0-0/libvpd-1.5.0.tar.gz -rw------- 1 tasaka1 tasaka1 351239 2007-12-28 16:56 libvpd-1.5.0.tar.gz $ md5sum *1.5.0*gz *1.5.0*/*gz 3743138471c729313e5a7482bb2f0f69 libvpd-1.5.0.tar.gz 696ebca1f4b11dfee3beee0ae25b09a7 libvpd-1.5.0-0/libvpd-1.5.0.tar.gz ----------------------------------------------------------- * pkgconfig dependency - The package which contains pkgconfig .pc files should have "Requires: pkgconfig". This means that libvpd-devel (not libvpd) should have this Requires. * Timestamps - As said in comment 18, please try to use --------------------------------------------------------------- %{__make} install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p" --------------------------------------------------------------- to keep timestamps on installed files. * Defattr - Now we recommend %defattr(-,root,root,-) * Documents - Please add the following files to %doc. --------------------------------------------------------------- AUTHORS --------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review