https://bugzilla.redhat.com/show_bug.cgi?id=2213078 --- Comment #11 from shenlebantongying <shenlebantongying@xxxxxxxxx> --- Friends, I think the culprit responsible for "rpmlint warning: unused-direct-shlib-dependency " is this line: > -DCMAKE_BUILD_TYPE=Release \ The %cmake macro already set the correct optimization levels & other things via %set_build_flags The defination of %cmake: https://src.fedoraproject.org/rpms/cmake/blob/rawhide/f/macros.cmake.in The --as-needed is added here, and it is included in %set_build_flags https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/f38/f/macros#_352 Adding -DCMAKE_BUILD_TYPE=Release will append extra things to CXXFLAGS, which may conflict with existing flags. --- Other CMake packages are built without -DCMAKE_BUILD_TYPE. Such as * https://src.fedoraproject.org/rpms/qbittorrent/blob/rawhide/f/qbittorrent.spec Or a complete search of fedora's packages: https://sourcegraph.com/search?q=context%3Aglobal+repo%3A%5Esrc.fedoraproject.org%2F+file%3A%5C.spec%24+%25cmake&patternType=regexp&sm=0&groupBy=repo (Note that there are a few existing packages that include `-DCMAKE_BUILD_TYPE`, which might be an error. Maybe a new task/bug should be filed somewhere to clean them up?) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2213078 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202213078%23c11 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
