[Bug 2224193] Review Request: ipcgull - A GDBus-based IPC library for modern C++

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2224193



--- Comment #1 from Vasiliy Glazov <vascom2@xxxxxxxxx> ---
1. Why debug_package %{nil} ?

2. Release: 0%{?dist}
must be 
Release: 1%{?dist}

3. Need to change License: GPLv3
to
License: GPL-3.0-or-later

4. For devel package need to change Requires:       %{name} =
%{version}-%{release}
to
Requires:       %{name}%{?_isa} = %{version}-%{release}

5. All at %prep section can be changed to %autosetup

6. install -D -m 755
must be changed to
install -D -pm 755

7. Remove %ldconfig_scriptlets


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2224193

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202224193%23c1
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux