https://bugzilla.redhat.com/show_bug.cgi?id=2180243 --- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> --- Four months later... I'm very sorry for the huge delay. I got swamped with more urgent matters, and it has taken me this long to dig my way out of the pile and get back to this. I have updated the COPR (https://copr.fedorainfracloud.org/coprs/jjames/MuseScore4/) with new builds, and MuseScore 4.1.0. (In reply to Alexander Ploumistos from comment #4) > [x]: License field in the package spec file matches the actual license. > * I did my best to verify the licenses mentioned in the spec file, they seem > right and kudos for sorting that mess. Besides that, rpmlint has this to say: > musescore.x86_64: E: incorrect-fsf-address > /usr/share/licenses/musescore/COPYING.LESSER.rtf2html > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/cchords_muse.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/cchords_nrb.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/cchords_rb.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/cchords_sym.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/chords.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/chords_jazz.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/chords_std.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/jazzchords.xml > musescore.x86_64: E: incorrect-fsf-address > /usr/share/mscore-4.0/styles/stdchords.xml > I think these should be reported and fixed upstream. https://github.com/musescore/MuseScore/issues/18710 > [x]: Package must own all directories that it creates. > * Why use both the old and new name in paths and files? The fact that both mscore and musescore appear in upstream's distribution is probably what led to the package being named mscore in the first place. Upstream has selected the file and path names, not me. > [?]: Package contains no bundled libraries without FPC exception. > * I see the unbundled libraries and what remains bundled, shouldn't this be > in the "SHOULD" section? Yes. I believe the package complies with https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling. > [x]: Package does not contain duplicates in %files. > * Some of these duplicates reported by rpmlint appear to be false positives, > but not all of them: > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/locale/musescore_ar_DZ.qm > /usr/share/mscore-4.0/locale/instruments_ar_DZ.qm > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/plugins/tuning_modal/modal_tuning.png > /usr/share/mscore-4.0/plugins/tuning/modal_tuning.png > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/05-Jazz/01-Jazz_Lead_Sheet/audiosettings. > json > /usr/share/mscore-4.0/templates/01-General/01-Treble_Clef/audiosettings.json: > /usr/share/mscore-4.0/templates/01-General/02-Bass_Clef/audiosettings.json:/ > usr/share/mscore-4.0/templates/01-General/03-Grand_Staff/audiosettings.json:/ > usr/share/mscore-4.0/templates/02-Choral/10-Liturgical_Unmetrical/ > audiosettings.json:/usr/share/mscore-4.0/templates/04-Solo/01-Guitar/ > audiosettings.json:/usr/share/mscore-4.0/templates/04-Solo/02- > Guitar_+_Tablature/audiosettings.json:/usr/share/mscore-4.0/templates/04- > Solo/03-Guitar_Tablature/audiosettings.json:/usr/share/mscore-4.0/templates/ > 04-Solo/04-Piano/audiosettings.json > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/07-Band_and_Percussion/06-Battery_Percussion/ > score_style.mss > /usr/share/mscore-4.0/templates/01-General/01-Treble_Clef/score_style.mss:/ > usr/share/mscore-4.0/templates/01-General/02-Bass_Clef/score_style.mss:/usr/ > share/mscore-4.0/templates/01-General/03-Grand_Staff/score_style.mss:/usr/ > share/mscore-4.0/templates/02-Choral/01-SATB/score_style.mss:/usr/share/ > mscore-4.0/templates/02-Choral/02-SATB_+_Organ/score_style.mss:/usr/share/ > mscore-4.0/templates/02-Choral/03-SATB_+_Piano/score_style.mss:/usr/share/ > mscore-4.0/templates/02-Choral/04-SATB_Closed_Score/score_style.mss:/usr/ > share/mscore-4.0/templates/02-Choral/05-SATB_Closed_Score_+_Organ/ > score_style.mss:/usr/share/mscore-4.0/templates/02-Choral/06- > SATB_Closed_Score_+_Piano/score_style.mss:/usr/share/mscore-4.0/templates/02- > Choral/07-Voice_+_Piano/score_style.mss:/usr/share/mscore-4.0/templates/02- > Choral/08-Barbershop_Quartet_(Men)/score_style.mss:/usr/share/mscore-4.0/ > templates/02-Choral/09-Barbershop_Quartet_(Women)/score_style.mss:/usr/share/ > mscore-4.0/templates/04-Solo/01-Guitar/score_style.mss:/usr/share/mscore-4.0/ > templates/04-Solo/02-Guitar_+_Tablature/score_style.mss:/usr/share/mscore-4. > 0/templates/04-Solo/03-Guitar_Tablature/score_style.mss:/usr/share/mscore-4. > 0/templates/04-Solo/04-Piano/score_style.mss > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/08-Orchestral/03-String_Orchestra/ > viewsettings.json > /usr/share/mscore-4.0/templates/01-General/01-Treble_Clef/viewsettings.json:/ > usr/share/mscore-4.0/templates/01-General/02-Bass_Clef/viewsettings.json:/ > usr/share/mscore-4.0/templates/01-General/03-Grand_Staff/viewsettings.json:/ > usr/share/mscore-4.0/templates/02-Choral/01-SATB/viewsettings.json:/usr/ > share/mscore-4.0/templates/02-Choral/02-SATB_+_Organ/viewsettings.json:/usr/ > share/mscore-4.0/templates/02-Choral/03-SATB_+_Piano/viewsettings.json:/usr/ > share/mscore-4.0/templates/02-Choral/04-SATB_Closed_Score/viewsettings.json:/ > usr/share/mscore-4.0/templates/02-Choral/05-SATB_Closed_Score_+_Organ/ > viewsettings.json:/usr/share/mscore-4.0/templates/02-Choral/06- > SATB_Closed_Score_+_Piano/viewsettings.json:/usr/share/mscore-4.0/templates/ > 02-Choral/07-Voice_+_Piano/viewsettings.json:/usr/share/mscore-4.0/templates/ > 02-Choral/08-Barbershop_Quartet_(Men)/viewsettings.json:/usr/share/mscore-4. > 0/templates/02-Choral/09-Barbershop_Quartet_(Women)/viewsettings.json:/usr/ > share/mscore-4.0/templates/02-Choral/10-Liturgical_Unmetrical/viewsettings. > json:/usr/share/mscore-4.0/templates/02-Choral/11- > Liturgical_Unmetrical_+_Organ/viewsettings.json:/usr/share/mscore-4.0/ > templates/03-Chamber_Music/01-String_Quartet/viewsettings.json:/usr/share/ > mscore-4.0/templates/03-Chamber_Music/02-Wind_Quartet/viewsettings.json:/usr/ > share/mscore-4.0/templates/03-Chamber_Music/03-Wind_Quintet/viewsettings. > json:/usr/share/mscore-4.0/templates/03-Chamber_Music/04-Saxophone_Quartet/ > viewsettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/05- > Brass_Quartet/viewsettings.json:/usr/share/mscore-4.0/templates/03- > Chamber_Music/06-Brass_Quintet/viewsettings.json:/usr/share/mscore-4.0/ > templates/04-Solo/01-Guitar/viewsettings.json:/usr/share/mscore-4.0/ > templates/04-Solo/02-Guitar_+_Tablature/viewsettings.json:/usr/share/mscore- > 4.0/templates/04-Solo/03-Guitar_Tablature/viewsettings.json:/usr/share/ > mscore-4.0/templates/04-Solo/04-Piano/viewsettings.json:/usr/share/mscore-4. > 0/templates/05-Jazz/01-Jazz_Lead_Sheet/viewsettings.json:/usr/share/mscore-4. > 0/templates/05-Jazz/02-Big_Band/viewsettings.json:/usr/share/mscore-4.0/ > templates/05-Jazz/03-Jazz_Combo/viewsettings.json:/usr/share/mscore-4.0/ > templates/06-Popular/01-Rock_Band/viewsettings.json:/usr/share/mscore-4.0/ > templates/06-Popular/02-Bluegrass_Band/viewsettings.json:/usr/share/mscore-4. > 0/templates/07-Band_and_Percussion/01-Concert_Band/viewsettings.json:/usr/ > share/mscore-4.0/templates/07-Band_and_Percussion/02-Small_Concert_Band/ > viewsettings.json:/usr/share/mscore-4.0/templates/07-Band_and_Percussion/03- > Brass_Band/viewsettings.json:/usr/share/mscore-4.0/templates/07- > Band_and_Percussion/04-Marching_Band/viewsettings.json:/usr/share/mscore-4.0/ > templates/07-Band_and_Percussion/05-Small_Marching_Band/viewsettings.json:/ > usr/share/mscore-4.0/templates/07-Band_and_Percussion/06-Battery_Percussion/ > viewsettings.json:/usr/share/mscore-4.0/templates/07-Band_and_Percussion/07- > Large_Pit_Percussion/viewsettings.json:/usr/share/mscore-4.0/templates/07- > Band_and_Percussion/08-Small_Pit_Percussion/viewsettings.json:/usr/share/ > mscore-4.0/templates/07-Band_and_Percussion/09-European_Concert_Band/ > viewsettings.json:/usr/share/mscore-4.0/templates/08-Orchestral/01- > Classical_Orchestra/viewsettings.json:/usr/share/mscore-4.0/templates/08- > Orchestral/02-Symphony_Orchestra/viewsettings.json > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/07-Band_and_Percussion/06-Battery_Percussion/ > audiosettings.json > /usr/share/mscore-4.0/templates/02-Choral/01-SATB/audiosettings.json:/usr/ > share/mscore-4.0/templates/03-Chamber_Music/01-String_Quartet/audiosettings. > json:/usr/share/mscore-4.0/templates/03-Chamber_Music/02-Wind_Quartet/ > audiosettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/04- > Saxophone_Quartet/audiosettings.json:/usr/share/mscore-4.0/templates/03- > Chamber_Music/05-Brass_Quartet/audiosettings.json > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/08-Orchestral/03-String_Orchestra/ > audiosettings.json > /usr/share/mscore-4.0/templates/02-Choral/02-SATB_+_Organ/audiosettings.json: > /usr/share/mscore-4.0/templates/02-Choral/03-SATB_+_Piano/audiosettings.json: > /usr/share/mscore-4.0/templates/03-Chamber_Music/03-Wind_Quintet/ > audiosettings.json:/usr/share/mscore-4.0/templates/03-Chamber_Music/06- > Brass_Quintet/audiosettings.json > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/02-Choral/11-Liturgical_Unmetrical_+_Organ/ > audiosettings.json > /usr/share/mscore-4.0/templates/02-Choral/04-SATB_Closed_Score/audiosettings. > json:/usr/share/mscore-4.0/templates/02-Choral/07-Voice_+_Piano/ > audiosettings.json:/usr/share/mscore-4.0/templates/02-Choral/08- > Barbershop_Quartet_(Men)/audiosettings.json:/usr/share/mscore-4.0/templates/ > 02-Choral/09-Barbershop_Quartet_(Women)/audiosettings.json > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/02-Choral/06-SATB_Closed_Score_+_Piano/ > audiosettings.json > /usr/share/mscore-4.0/templates/02-Choral/05-SATB_Closed_Score_+_Organ/ > audiosettings.json > musescore.x86_64: W: files-duplicate > /usr/share/mscore-4.0/templates/03-Chamber_Music/05-Brass_Quartet/ > score_style.mss > /usr/share/mscore-4.0/templates/03-Chamber_Music/01-String_Quartet/ > score_style.mss:/usr/share/mscore-4.0/templates/03-Chamber_Music/02- > Wind_Quartet/score_style.mss:/usr/share/mscore-4.0/templates/03- > Chamber_Music/03-Wind_Quintet/score_style.mss:/usr/share/mscore-4.0/ > templates/03-Chamber_Music/04-Saxophone_Quartet/score_style.mss Hmmm, I'm not sure what to do about these. Those are files created and installed by upstream. I suppose I could run hardlink over the installed tree. Does RPM handle hardlinked files correctly? (And *should* these files be hardlinked? I'm not at all sure about that.) > [!]: %check is present and all tests pass. > * I think that "desktop-file-validate" and "appstreamcli validate" should be > under %check, no? https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage says that desktop-file-validate can be run in either %install or %check. Likewise, https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage says that appstream-util can be run in either %install or %check. Again, my apologies for going silent. I should have time to stay on top of this review going forward, unless Murphy decides to smite me again. New URLs: Spec URL: https://jjames.fedorapeople.org/musescore/musescore.spec SRPM URL: https://jjames.fedorapeople.org/musescore/musescore-4.1.0-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2180243 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202180243%23c5 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
