[Bug 2218606] Review Request: migrate - Go database migrations library and program

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2218606



--- Comment #16 from Link Dupont <link@xxxxxxxxxxx> ---
You're correct. Using build tags just alters the state of the `migrate` binary,
but doesn't change the resulting "gocode" package. I assumed that having source
files in the -devel package would be harmless enough, but it appears that
they're still used to generate dependencies. I reworked the spec file
significantly again. This time I took the "removal approach" as you suggest. I
also took the time to include any driver that has dependencies already packaged
in Fedora. So the drivers that are removed are the ones that are missing a
dependency. It's not as daunting a list as I first assumed, but it's still
large enough that I don't want to complicate this review unnecessarily. The
good news is many common database and source drivers are now included.

Spec URL: https://linkdupont.fedorapeople.org/reviews/migrate.spec
SRPM URL:
https://linkdupont.fedorapeople.org/reviews/migrate-4.16.2-1.fc39.src.rpm
Fedora Review:
https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora-38-x86_64/06186335-migrate/fedora-review


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2218606

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c16
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux