[Bug 2223011] Review Request: python-chalice - Python Serverless Microframework for AWS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2223011



--- Comment #2 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> ---
Initial pass:

- could use %pyproject_buildrequires -r requirements-test.in
(requirements-test.txt locks in the versions required). that way you don't have
to manually specify test dependencies
- patch requirements-test.in so it does not pull in python3-mock which is
deprecated. And patch the callsites to do `from unittest import mock` rather
than `import mock` and upstream that

potentially use try / except:

try:
  from unittest import mock
except:
  import mock

Note that somehow it doesn't pick up `python3dist(inquirer)` even though I
point fedora-review to the correct local repo

$ rpm -qp --provides ../../repo/python3-inquirer-3.1.3-1.fc38.noarch.rpm
python-inquirer = 3.1.3-1.fc38
python3-inquirer = 3.1.3-1.fc38
python3.11-inquirer = 3.1.3-1.fc38
python3.11dist(inquirer) = 3.1.3
python3dist(inquirer) = 3.1.3


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2223011

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202223011%23c2
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux