https://bugzilla.redhat.com/show_bug.cgi?id=2223473 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the review! (In reply to Fabio Valentini from comment #2) > - disabling tests due to missing dependencies for tests is OK (though you could look into whether you could just drop tests with missing dependencies and run the rest) I gave that a try today. I had to omit several missing dependencies (e.g., commons-dbcp2, commons-pool2, hsqldb). Then there was an incompatibility with modern versions of javax.servlet that I had to patch around. Then the test code refers to jakarta.mail instead of javax.mail, requiring another patch. Then I found that the Fedora apache-commons-logging package disables log4j support, and the commons-configuration tests assume EVERYWHERE that log4j support is available via commons-logging. At this point I am giving up. > Previously, both apache-commons-configuration and > apache-commons-configuration2 existed in Fedora, and commons-configuration2 > (which is what we're looking at here) was packaged as > apache-ommons-configuration2, while commons-configuration (version 1) was > packaged as apache-commons-configuration. Considering the length of time that has passed, and the fact that nobody has requested the return of commons-configuration version 1, I think I would like to stick with the current naming. If version 3 is ever released, my preference would be to introduce apache-commons-configuration2 to hold version 2 (if needed), and have apache-commons-configuration move on to version 3. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2223473 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202223473%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
