https://bugzilla.redhat.com/show_bug.cgi?id=2223473 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |decathorpe@xxxxxxxxx Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- fedora-review is broken in rawhide, so here's a manual review: - package name matches other Apache commons-* projects - latest version is packaged - Summary / description are fine and correctly line-wrapped - source archive contains only source files and no objectionable content - source archive contains only files under Apache-2.0 license - License matches upstream specification, license text included - signature of source file verified with gpg - Patch to update JEXL dependency to latest version documented and justified (not sure if it's worth upstreaming, Apache Commons is not the easiest project to contribute to) - BuildRequires look sane (though I could not verify them, xmvn-builddep seems to be broken again) - docs are built and included in a separate package - removal of unnecessary maven plugins is fine and justified - build uses standard mvn_build / mvn_install macros - disabling tests due to missing dependencies for tests is OK (though you could look into whether you could just drop tests with missing dependencies and run the rest) - disabling optional features due to missing dependencies is OK (I don't blame you for not wanting to package the Spring framework) - included %files look sane === You can continue the unretirement process with releng after considering the following: Previously, both apache-commons-configuration and apache-commons-configuration2 existed in Fedora, and commons-configuration2 (which is what we're looking at here) was packaged as apache-ommons-configuration2, while commons-configuration (version 1) was packaged as apache-commons-configuration. Both have been retired for 5+ releases, but please check whether you want to package this as apache-commons-configuration2 (matches the upstream filename / jar name) or apache-commons-configuration (which was previously only for version 1). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2223473 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202223473%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
