[Bug 2223443] Review Request: frozen - A header-only, constexpr alternative to gperf for C++14 users

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2223443

Michael J Gruber <mjg@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |mjg@xxxxxxxxxxxxxxxxx



--- Comment #2 from Michael J Gruber <mjg@xxxxxxxxxxxxxxxxx> ---
Comments on first sight:

Fedora review broken on copr.

Release build (instead of debug) is OK because the package is header only.
(Maybe include a comment in spec or so)

Build fails on Fedora 37 because a constexpr is recognized as such. This may be
due to the gcc version (in which case the spec should specify a minimum
version), but might also be fixed by some of the upstream commits after 1.1.1,
maybe this one:

https://github.com/serge-sans-paille/frozen/commit/f6dbec6d03debc68d18ae3e2d32ff408c6d52468

Is include.patch submitted upstream?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2223443

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202223443%23c2
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux