https://bugzilla.redhat.com/show_bug.cgi?id=2222811 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |decathorpe@xxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- fedora-review is broken in rawhide, so here's a manual review: - package name matches other Apache commons-* projects - latest version is packaged - Summary / description are fine and correctly line-wrapped - source archive contains only source files and no objectionable content - source archive contains only files under Apache-2.0 license - License matches upstream specification, license text included - signature of source file verified with gpg - Patch to replace one build dependency with another one documented and justified - BuildRequires look sane (though I could not verify them, xmvn-builddep seems to be broken again) - docs are built and included in a separate package - removal of unnecessary maven plugins is fine and justified - build uses standard mvn_build / mvn_install macros - unit tests are run and are all successful - included %files look sane - looks good to me Package APPROVED. === You can continue the unretirement process with releng. Note that if you want to preserve pre-retirement changelog, you'll probably need to be careful when converting to rpmautospec (I think running "rpmautospec convert" immediately after the unretirement commit and then commiting your new version on top of that should work). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2222811 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202222811%23c2 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
