https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@xxxxxxxxxxxxxxx --- Comment #1 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- > %global godocs CONTRIBUTING.md FAQ.md GETTING_STARTED.md MIGRATIONS.md README.md SECURITY.md cmd/migrate/README.md database/sqlite3/README.md source/iofs/README.md This line is too long and those README files won't be installed correctly, you need to rename them. Check "golang-github-cloudflare-circl.spec" on how ecc-p384-LICENSE is created for example. > for cmd in cmd/* ; do > BUILDTAGS="%{_gobuildtags}" %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd > done It may be just a style thing, but I would split the line in a export and the build command: export BUILDTAGS="%{_gobuildtags}" %gobuild -o %{gobuilddir}/bin/migrate %{goipath}/cmd/migrate > %check > # Tests are skipped because they rely on dktest, a container testing harness > # that expects to have access to the Internet as well as a running docker daemon > # on the test host. This also would be style thing, but I found that usually we just add a bcond in the top for check and just leave the regular %check / %gocheck. In golang-github-git-5.spec for example: # Needs network access to Github %bcond_with check (...) %if %{with check} %check %gocheck %endif -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2218606 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202218606%23c1 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
