[Bug 2223224] Review Request: fractal - Matrix group messaging app

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2223224



--- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
(In reply to Pete Walter from comment #4)
> Fabio: You are wrong. Packaging Guidelines allow bundled dependencies if we
> cannot use system libraries. In this case a lot of bundled rust libraries
> are missing so we cannot use the system libraries. Feel free to add them to
> fedora and let me know.

I checked the bundled dependencies, and like 95% of them are already available
in Fedora.
The biggest missing piece is the Matrix SDK, which is included as a git
snapshot.
Since we cannot package those separately, bundling those is OK.
As far as I can tell, that only leaves a handful of missing crates.

> For the record, I wanted to avoid bundled libraries at first but after you
> flat out refused to let me take keep the rust dependencies that fractal
> needs from retirement (please kindly refer to
> https://pagure.io/releng/issue/11372) I have given up on that.

I'm sorry how that turned out. It seems that there was a misunderstanding.
If you read that ticket, I actually offered help with packaging whatever you
were working on, I just objected to the fact that you wanted to become new main
maintainer of a few packages that I was still maintaining in stable branches,
but which were retired in rawhide.

> If you want
> fractal to use packaged dependencies, feel free to go ahead and add them to
> fedora and I will switch over to them but I am done with interacting with
> someone who just flat out refuses to cooperate.

I offered help the second I saw that you wanted to unretire Rust packages.
I'm not sure how that qualifies as "refusing to cooperate" ...

> I will work on adding bundled() provides next weekend. Thank you for
> pointing that out.

You can use the %cargo_license and %cargo_license_summary macros as well.
They simplify the task of creating an accurate License tag (which is missing
from the package right now).
That's the more important reason I'd have not approved this package as-is -
bundling your dependencies is OK in some circumstances, but inaccurate license
tag never is.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2223224

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202223224%23c5
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux