[Bug 2222367] Review Request: python-rpds-py - Python bindings to the Rust rpds crate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2222367



--- Comment #8 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
(In reply to Mattia Verga from comment #7)
> Ok, so I've updated the specfile by manually adding the license files with
> %license macro.
> This obviously will install duplicated license files, as %license macro
> copies files in the appropriate dir. Or should I now manually delete the
> license under the python metadata directory?

Removing the license files under the Python metadata directory would be wrong,
in my opinion; they belong there, and they are there in the PyPI wheels.

Trying to manually add %license to the absolute paths in the Python metadata
directory could be technically workable, but is far too fussy in my opinion.

Ignoring the duplicates is the usual approach, and is unproblematic.

----

I’m actually surprised this doesn’t work; given
https://github.com/PyO3/maturin/pull/862, it looks like it’s supposed to. I’m
not going to investigate right now, though...


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2222367

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202222367%23c8
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux